Re: [Xen-devel] [PATCH] xl: HVM domain S3 bugfix

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Ian Campbell wrote:
>> --- a/tools/libxl/libxl.c
>> +++ b/tools/libxl/libxl.c
>> @@ -4641,6 +4641,33 @@ int libxl_domain_sched_params_get(libxl_ctx
>>  *ctx, uint32_t domid,      return ret; }
>> 
>> +static int xc_domain_s3_resume(libxl_ctx *ctx, int domid)
> 
> Since this is an internal function it should be
> static int libxl__domain_s3_resume(libxl__gc *gc, int domid)
> 
>> +{
>> +    int rc = 0;
>> +    GC_INIT(ctx);
> 
> This (and the corresponding GC_FREE) should be added to
> libxl_send_trigger, so that you have a gc to pass to this function.
> 
>> +
>> +    switch (libxl__domain_type(gc, domid)) {
>> +    case LIBXL_DOMAIN_TYPE_HVM:
>> +        switch (libxl__device_model_version_running(gc, domid)) {
>> +        case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL:
>> +            rc = xc_set_hvm_param(ctx->xch, domid,
>> HVM_PARAM_ACPI_S_STATE, 0); 
> 
> With the above changes will become CTX->xch.
> 

Thanks! sorry for late reply (just return from a short vacation).
Patch updated and already sent out.

Regards,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel