Re: [Xen-devel] [RFC 03/24] xen/dts: Don't check the number of address and size cells in process_cpu_node

[Chen Baozi <baozich@xxxxxxxxx>]

On Aug 17, 2013, at 5:05 AM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

> The properties #address-cells and #size-cells is not required in /cpus node in
> the device tree (see Linux Documentation/devicetree/booting-without-of.txt
> Section III.5.a).
> 
> In the OMAP5 device tree, these 2 properties are not defined. Therefore, Xen
> will only able to handle 1 CPU.

Well, these 2 properties are defined in the latest upstream codes. They are just
not defined in the kernel tree shipped with TI devboard which version is 3.8.2.

For the others, this patch looks good for me.

> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> CC: andrii.anisov@xxxxxxxxxxxxxxx
> CC: baozich@xxxxxxxxx
Acked-by: Chen Baozi <baozich@xxxxxxxxx>

> ---
> xen/common/device_tree.c |    6 ------
> 1 file changed, 6 deletions(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 84d704d..51f23eb 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -414,12 +414,6 @@ static void __init process_cpu_node(const void *fdt, int 
> node,
>     const u32 *cell;
>     paddr_t start, size;
> 
> -    if ( address_cells != 1 || size_cells != 0 )
> -    {
> -        early_printk("fdt: node `%s': invalid #address-cells or #size-cells",
> -                     name);
> -        return;
> -    }
> 
>     prop = fdt_get_property(fdt, node, "reg", NULL);
>     if ( !prop )
> -- 
> 1.7.10.4
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel