Re: [Xen-devel] [PATCH] x86/boot: Explicitly clean pcpu stacks in debug builds

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.08.13 at 22:49, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/boot/x86_64.S
> +++ b/xen/arch/x86/boot/x86_64.S
> @@ -13,6 +13,15 @@
>          mov     mmu_cr4_features(%rip),%rcx
>          mov     %rcx,%cr4
>  
> +#ifndef NDEBUG
> +        /* Clean stack. */
> +        mov     stack_start(%rip),%rdi
> +        mov     $(STACK_SIZE>>8),%rcx

Probably you meant STACK_SIZE / 8?

> +#ifndef NDEBUG
> +    for ( order = 0 ; order < 1<<STACK_ORDER ; ++order )

Please parenthesize the shift operation.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel