Re: [Xen-devel] [PATCH 4/7] Nested VMX: Add interface to update vPPR

["Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>]

Jan Beulich wrote on 2013-08-09:
>>>> On 09.08.13 at 10:49, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>> From: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>> 
>> Add vlapic_set_ppr() to allow update vPPR which in virtual apic page.
> 
> Again, missing the consumer of this new function.
It is used in patch 6. I will mention it in comments.

> 
>> +uint32_t vlapic_set_ppr(struct vlapic *vlapic) {
>> +   uint32_t ppr = vlapic_get_ppr(vlapic);
>> +   vlapic_set_reg(vlapic, APIC_PROCPRI, ppr);
> 
> Blank line needed between variable declarations and first statement.
Sure.

> 
> Jan


Best regards,
Yang



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel