Re: [Xen-devel] [PATCH 5/7] Nested VMX: Check whether interrupt is blocked by TPR

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.08.13 at 12:43, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/hvm/vmx/intr.c
>> +++ b/xen/arch/x86/hvm/vmx/intr.c
>> @@ -165,6 +165,11 @@ static int nvmx_intr_intercept(struct vcpu *v, struct 
>> hvm_intack intack)
>>  {
>>      u32 ctrl;
>>  
>> +    /* If blocked by L1's tpr, then do nothing*/
> 
> As you need to respin, please have a space at the end of the sentence
> before */

And a period. See CODING_STYLE. Also, I think rather than "do
nothing", "nothing to do" would better describe things here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel