Re: [Xen-devel] [PATCH v5 5/5] xen/arm: Platform recognition and initialize arch_timer for the OMAP5

[Chen Baozi <baozich@xxxxxxxxx>]

On Aug 8, 2013, at 8:18 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> On Thu, 2013-08-08 at 18:52 +0800, Chen Baozi wrote:
>> Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> I suppose this cannot be applied without some of the precursors from
> this series?

It only depends on patch #4.

And thanks for pointing out the typos, :)

Cheers,

Baozi

> 
> A few typos:
>> ---
>> + * xen/arch/arm/platforma/omap5.c
> 
> "platforms"
> 
>> + *
>> + * OMAP5 specific settings
>> + *
>> + * Chen Baozi <baozich@xxxxxxxxx>
>> + * Copyright (c) 2013
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributted in the hope that it will be useful,
> 
> "distributted"
> 
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU Gerneral Public License for more details.
> 
> "General"
> 
> I checked the rest of the tree and you must have introduced these after
> copying the block ;-)
> 
>> + */
>> +
>> +#include <xen/config.h>
>> +#include <asm/platform.h>
>> +#include <asm/platforms/omap5.h>
>> +#include <xen/mm.h>
>> +#include <xen/vmap.h>
>> +
>> +static uint16_t num_den[8][2] = {
>> +    {         0,          0 },  /* not used */
>> +    {  26 *  64,  26 *  125 },  /* 12.0 Mhz */
>> +    {   2 * 768,   2 * 1625 },  /* 13.0 Mhz */
>> +    {         0,          0 },  /* not used */
>> +    { 130 *   8, 130 *   25 },  /* 19.2 Mhz */
>> +    {   2 * 384,   2 * 1625 },  /* 26.0 Mhz */
>> +    {   3 * 256,   3 * 1125 },  /* 27.0 Mhz */
>> +    { 130 *   4, 130 *   25 },  /* 38.4 Mhz */
>> +};
>> +
>> +/*
>> + * The realtime counter also called master counter, is a free-running
>> + * counter, which is related to real time. It produces the count used
>> + * by the CPU local timer peripherals in teh MPU cluster. The timer counts
> 
> teh -> the
> 
> Ian.
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel