Re: [Xen-devel] [PATCH v6 3/5] xen: arm: include public/xen.h in foreign interface checking

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH v6 3/5] xen: arm: include 
public/xen.h in foreign interface checking"):
> IIRC the magic in mkheader.py requires
>         #ifdef FOO
>         struct ...
>         
> and cannot cope with 
> 
>         #ifdef FOO
>         #define BAR
>         struct ...
>         
> I could make the regex more complicated to cope with this case but just
> moving the #define next to its only usage seemed simpler.

Urgh.  Right.

> I rewrote the final line of the changelog to be:
> 
>    Teach mkheader.py to cope with structs which are ifdef'd. This cannot cope
>    with #defines between the #ifdef and the struct definitions, so move
>    MAX_GUEST_CMDLINE to be next to its only usage.
> 
> Does that suffice?

Yes, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel