Re: [Xen-devel] [V10 PATCH 10/23] PVH xen: domain create, context switch related code changes

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Wed, 7 Aug 2013 11:48:26 +0100
George Dunlap <George.Dunlap@xxxxxxxxxxxxx> wrote:

> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor
> <mukesh.rathor@xxxxxxxxxx> wrote:
..........
> > +
> >          v->arch.guest_table = pagetable_from_page(cr3_page);
> > -        if ( c.nat->ctrlreg[1] )
> > +        if ( c.nat->ctrlreg[1] && !is_pvh_vcpu(v) )
> >          {
> >              cr3_gfn = xen_cr3_to_pfn(c.nat->ctrlreg[1]);
> >              cr3_page = get_page_from_gfn(d, cr3_gfn, NULL,
> > P2M_ALLOC); @@ -954,6 +965,13 @@ int arch_set_info_guest(
> >
> >      update_cr3(v);
> >
> > +    if ( is_pvh_vcpu(v) )
> > +    {
> > +        /* Set VMCS fields. */
> > +        if ( (rc = pvh_set_vcpu_info(v, c.nat)) != 0 )
> > +            return rc;
> > +    }
> 
> BTW, would it make sense to pull the code above, which sets FS and GS
> for PV guests into a separate function, and then do something like the
> following?
> 
>  is_pv_vcpu(v) ?
>    pv_set_vcpu_info() :
>    pvh_set_vcpu_info();

Perhaps! But, these patches have been out for about 7 months now, and
are tested by us and Andrew for PV and HVM regressions. I prefer not 
changing common code at this point, unless buggy. May be we can do an
incremental change later if you really want this function to be
re-org'd.

thanks
mukesh


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel