Re: [Xen-devel] [V10 PATCH 16/23] PVH xen: mtrr, tsc, timers, grant changes...

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> PVH only supports limited memory types in Phase I. TSC is limited to
> native mode only also for the moment. Finally, grant mapping of iomem
> for PVH hasn't been explored in phase I.
>
> Changes in V10:
>   - don't migrate timers for PVH as it doesn't use rtc or emulated timers.
>
> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/hvm.c   |    4 ++++
>  xen/arch/x86/hvm/mtrr.c  |    8 ++++++++
>  xen/arch/x86/time.c      |    8 ++++++++
>  xen/common/grant_table.c |    4 ++--
>  4 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index bac4708..93aa42c 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -301,6 +301,10 @@ u64 hvm_get_guest_tsc_adjust(struct vcpu *v)
>
>  void hvm_migrate_timers(struct vcpu *v)
>  {
> +    /* PVH doesn't use rtc and emulated timers, it uses pvclock mechanism. */
> +    if ( is_pvh_vcpu(v) )
> +        return;

Would it make sense to move this one in with 13/NN,
"interrupt/event-channel delivery to PVH", since you're dealing with
timers there as well?  That would group things more by feature than by
where it is in the code.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel