Re: [Xen-devel] [PATCH] scmversion: Improve svn interaction.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/08/13 16:44, Ian Campbell wrote:
> On Thu, 2013-08-01 at 13:45 +0100, Andrew Cooper wrote:
>> Prevent running svn if .svn is not found; some versions of svn will
>> unconditionally create it.
> I was kind of hoping "improve" might mean "delete" ;-)
>
> We must have inherited this from the Linux version. I can't imagine any
> reason why you would ever have wanted to import Xen (or Linux for that
> matter) into a svn tree.
>
> Ian.

And guess where we found the svn bug ;-)

I will gladly delete the svn stuff if wanted, but figured this was
slightly neater and more friendly to people.

~Andrew

>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> CC: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> CC: Keir Fraser <keir@xxxxxxx>
>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>> ---
>>  xen/tools/scmversion |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/tools/scmversion b/xen/tools/scmversion
>> index b0c3b95..ccc6334 100755
>> --- a/xen/tools/scmversion
>> +++ b/xen/tools/scmversion
>> @@ -77,7 +77,7 @@ scm_version()
>>      fi
>>  
>>      # Check for svn and a svn repo.
>> -    if rev=`LANG= LC_ALL= LC_MESSAGES=C svn info 2>/dev/null | grep '^Last 
>> Changed Rev'`; then
>> +    if test -d .svn && rev=`LANG= LC_ALL= LC_MESSAGES=C svn info 
>> 2>/dev/null | grep '^Last Changed Rev'`; then
>>              rev=`echo $rev | awk '{print $NF}'`
>>              printf -- 'svn:%s' "$rev"
>>  
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel