Re: [Xen-devel] [PATCH v2 4/8] xen/arm: New callback in uart_driver to retrieve serial information

[Tim Deegan <tim@xxxxxxx>]

At 16:38 +0100 on 31 Jul (1375288704), Julien Grall wrote:
> --- a/xen/include/xen/serial.h
> +++ b/xen/include/xen/serial.h
> @@ -32,6 +32,14 @@ enum serial_port_state {
>      serial_initialized
>  };
>  
> +struct vuart_info {
> +    unsigned long base_addr;    /* Base address of the UART */

Should this field be a paddr_t?

Cheers,

Tim.

> +    unsigned long size;         /* Size of the memory region */
> +    unsigned long data_off;     /* Data register offset */
> +    unsigned long status_off;   /* Status register offset */
> +    unsigned long status;       /* Ready status value */
> +};

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel