Re: [Xen-devel] [PATCH 0 of 4 RFC] xl - Remus network buffering support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-07-30 at 18:11 +0200, Roger Pau Monnà wrote:
> I've just skimmed quickly through the patches, but it seems like they
> add a bunch of Linux specific code to general parts of libxl, which
> would prevent building or using libxl in any OS different than Linux. If
> you have to add Linux specific code there's libxl_linux.c, but please
> remember to also add the necessary stubs to libxl_netbsd.c in order to
> not break libxl for OSes different than Linux.

Good point.

Since this looks like it might be a reasonable amount of code I think it
might be better to put it into a more semantic rather than OS based
location, e..g libxl_netlink.c or libxl_remus.c and the put the stubs in
libxl_no<xxx>.c and conditionally compile the right one (based on OS).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel