Re: [Xen-devel] [V10 PATCH 00/23]PVH xen: Phase I, Version 10 patches...

[Tim Deegan <tim@xxxxxxx>]

Hi,

At 18:59 -0700 on 23 Jul (1374605948), Mukesh Rathor wrote:
> These V10 patches are in pretty good shape. I've addressed all the
> issues Jan had in previous versions, and jfyi, he and I've been back
> and forth on pretty much every patch in this series. Lot of the patches
> have 'acked' or 'reviewed' tags. Kindly review.

If these aren't already committed, you can add my Reviewed-by to all
except 9, 10, 19 and 23.

For #10 if you just s/page_to_mfn/page_to_maddr/ that's good enough for
me, and it can have my Reviewed-by as well.

#9 and #23 I've commented on separately.

#19 is probably OK for correctness, though I haven't reviewed the VMCS
settings in enough detail to be sure they're complete.  My main
reservation is that it seems to duplicate a bunch of code from the
HVM VMCS setup.

One question that's not from any particular patch: is there a check
anywhere to stop the tools creating a PVH domain on an AMD machine?
I didn't see one but may just have missed it.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel