Re: [Xen-devel] [PATCH 2/3] xen/p2m: avoid unneccesary TLB flush in m2p_remove_override()

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 19 Jul 2013, David Vrabel wrote:
> From: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> In m2p_remove_override() when removing the grant map from the kernel
> mapping and replacing with a mapping to the original page, the grant
> unmap will already have flushed the TLB and it is not necessary to do
> it again after updating the mapping.
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Reviewed-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


>  arch/x86/xen/p2m.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
> index 95fb2aa..74672ee 100644
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -1003,7 +1003,6 @@ int m2p_remove_override(struct page *page,
>  
>                       set_pte_at(&init_mm, address, ptep,
>                                       pfn_pte(pfn, PAGE_KERNEL));
> -                     __flush_tlb_single(address);
>                       kmap_op->host_addr = 0;
>               }
>       }
> -- 
> 1.7.2.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel