Re: [Xen-devel] [PATCH] xl: Enable by default claim mode.

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, Jul 19, 2013 at 10:17 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2013-07-18 at 22:43 -0400, Konrad Rzeszutek Wilk wrote:
>> During the Xen 4.3 release we discussed that this feature could be
>> turned on by default - as it benefits all of the guests - not just
>> tmem related.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> [v1: Enable by default in the code, not just in the config file]
>> ---
>>  docs/man/xl.conf.pod.5 |    2 +-
>>  tools/examples/xl.conf |    2 +-
>>  tools/libxl/xl.c       |    2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/man/xl.conf.pod.5 b/docs/man/xl.conf.pod.5
>> index 1229c8a..125f786 100644
>> --- a/docs/man/xl.conf.pod.5
>> +++ b/docs/man/xl.conf.pod.5
>> @@ -139,7 +139,7 @@ Xen hypervisor argument and as well on the Linux kernel 
>> command line.
>>  Note that the claim call is not attempted if C<superpages> option is
>>  used in the guest config (see xl.cfg(5)).
>>
>> -Default: C<0>
>> +Default: C<1>
>>
>>  =over 4
>>
>> diff --git a/tools/examples/xl.conf b/tools/examples/xl.conf
>> index 9c037a6..d5a2384 100644
>> --- a/tools/examples/xl.conf
>> +++ b/tools/examples/xl.conf
>> @@ -31,5 +31,5 @@
>>  # Reserve a claim of memory when launching a guest. This guarantees 
>> immediate
>>  # feedback whether the guest can be launched due to memory exhaustion
>>  # (which can take a long time to find out if launching huge guests).
>> -# see xl.conf(5) for details.
>> +# see xl.conf(5) for details. By default it is enabled.
>>  #claim_mode=0
>  -#claim_mode=0
>  +#claim_mode=1
>
> Please.
>
> IOW the commented out value should reflect the default. No need for the
> additional words then either.

With that change:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel