Re: [Xen-devel] [PATCH v2 5/7] Do not break progress messages

[Atsushi Kumagai <kumagai-atsushi@xxxxxxxxxxxxxxxxx>]

On Tue, 16 Jul 2013 14:32:07 +0200
Daniel Kiper <daniel.kiper@xxxxxxxxxx> wrote:

> DEBUG_MSG() displaying erase info size breaks progress messages.
> Fix this by moving relevant DEBUG_MSG() to write_elf_eraseinfo().
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Good, I'll merge this patch into v1.5.5.


Thanks
Atsushi Kumagai

> ---
>  makedumpfile.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/makedumpfile.c b/makedumpfile.c
> index b4abbe5..a3bfc80 100644
> --- a/makedumpfile.c
> +++ b/makedumpfile.c
> @@ -5045,7 +5045,6 @@ write_elf_header(struct cache_data *cd_header)
>        * function.
>        */
>       info->size_elf_eraseinfo = size_eraseinfo;
> -     DEBUG_MSG("erase info size: %lu\n", info->size_elf_eraseinfo);
>  
>       /*
>        * Write a PT_NOTE header.
> @@ -6326,6 +6325,8 @@ write_elf_eraseinfo(struct cache_data *cd_header)
>       off_t offset_eraseinfo;
>       unsigned long note_header_size, size_written, size_note;
>  
> +     DEBUG_MSG("erase info size: %lu\n", info->size_elf_eraseinfo);
> +
>       if (!info->size_elf_eraseinfo)
>               return TRUE;
>  
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel