Re: [Xen-devel] [PATCH] x86: fix cache flushing condition in map_pages_to_xen()

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 17/07/2013 16:09, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> This fixes yet another shortcoming of the function (exposed by 8bfaa2c2
> ["x86: add locking to map_pages_to_xen()"]'s adjustment to
> msix_put_fixmap()): It must not flush caches when transitioning to a
> non-present mapping. Doing so causes the CLFLUSH to fault, if used in
> favor of WBINVD.
> 
> To help code readability, factor out the whole flush flags updating
> in map_pages_to_xen() into a helper macro.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I'd prefer the macro modified as I just posted, but either way:
Acked-by: Keir Fraser <keir@xxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel