Re: [Xen-devel] [PATCH] xen: allow architecture to choose whether to compress installed xen binary

[Ian Campbell <ijc@xxxxxxxxxxxxxx>]

On Mon, 2013-07-15 at 10:44 +0100, Jan Beulich wrote:
> >>> On 15.07.13 at 10:38, Ian Campbell <ijc@xxxxxxxxxxxxxx> wrote:
> > This is a follow up to "xen: arm: make zImage the default target which we
> > install".
> > 
> > On ARM the xen.gz binary installed into /boot is not immediately useful 
> > because
> > bootloaders (e.g. u-boot) do not unconditionally support decompression 
> > (except
> > via the uImage wrapper, which we currently do not support via our build 
> > system)
> 
> There are two changes I'd like to suggest:
> 
> > --- a/config/arm32.mk
> > +++ b/config/arm32.mk
> > @@ -2,6 +2,8 @@ CONFIG_ARM := y
> >  CONFIG_ARM_32 := y
> >  CONFIG_ARM_$(XEN_OS) := y
> >  
> > +CONFIG_INSTALL_COMPRESSED_XEN := n
> 
> Rename it suitably, leave it empty for ARM and set it to .gz on x86,
> allowing it to also be used for other purposes (like a different
> suffix if e.g. another compression method is supported on some
> platform).

Heh, my first (unposted) version did exactly that but I decided people
would prefer this way as a less intrusive change. I will change it back
and use CONFIG_INSTALL_XEN_SUFFIX perhaps?

> 
> > -_install: $(TARGET).gz
> > +_install: $(TARGET)$(GZ)
> >     [ -d $(DESTDIR)/boot ] || $(INSTALL_DIR) $(DESTDIR)/boot
> > -   $(INSTALL_DATA) $(TARGET).gz $(DESTDIR)/boot/$(notdir 
> > $(TARGET))-$(XEN_FULLVERSION).gz
> > -   ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
> > $(DESTDIR)/boot/$(notdir 
> > $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION).gz
> > -   ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
> > $(DESTDIR)/boot/$(notdir 
> > $(TARGET))-$(XEN_VERSION).gz
> > -   ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
> > $(DESTDIR)/boot/$(notdir 
> > $(TARGET)).gz
> > +   $(INSTALL_DATA) $(TARGET)$(GZ) $(DESTDIR)/boot/$(notdir 
> > $(TARGET))-$(XEN_FULLVERSION)$(GZ)
> > +   ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) 
> > $(DESTDIR)/boot/$(notdir 
> > $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)$(GZ)
> > +   ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) 
> > $(DESTDIR)/boot/$(notdir 
> > $(TARGET))-$(XEN_VERSION)$(GZ)
> > +   ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) 
> > $(DESTDIR)/boot/$(notdir 
> 
> As you're touching this block already, let's drop the .gz extension
> on the destination altogether - under /boot that's pretty
> meaningless anyway.

I'm slightly concerned about breaking bootloaders (or more specifically
their tooling like update-grub, grubby etc) here. I'm happy to make the
change but would prefer to do it as a separate patch (which negates your
"As you're touching" comment).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel