Re: [Xen-devel] [PATCH 1/2] libxl: Allow network driver domains when run_hotplug_scritps is set

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

Ping?

On Fri, Jul 5, 2013 at 12:13 PM, George Dunlap
<george.dunlap@xxxxxxxxxxxxx> wrote:
> As of commit 05bfd984dfe7014f1f5ea1133608b9bab589c120, hotplug scripts
> are not run if backend_domid != LIBXL_TOOSTACK_DOMID; so there is no reason
> to restrict this for network driver domains any more.
>
> This is a candidate for backporting to 4.3.
>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
> CC: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> ---
>  docs/misc/xl-network-configuration.markdown |    6 ++----
>  tools/libxl/libxl.c                         |    7 -------
>  2 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/docs/misc/xl-network-configuration.markdown 
> b/docs/misc/xl-network-configuration.markdown
> index e0d3d2a..3c439d4 100644
> --- a/docs/misc/xl-network-configuration.markdown
> +++ b/docs/misc/xl-network-configuration.markdown
> @@ -131,10 +131,8 @@ specified IP address to be used by the guest (blocking 
> all others).
>  ### backend
>
>  Specifies the backend domain which this device should attach to. This
> -defaults to domain 0. This option does not work if `run_hotplug_scripts`
> -is not disabled in xl.conf (see xl.conf(5) man page for more information
> -on this option). Specifying another domain requires setting up a driver
> -domain which is outside the scope of this document.
> +defaults to domain 0.  Specifying another domain requires setting up a
> +driver domain which is outside the scope of this document.
>
>  ### rate
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index bd63a30..81785df 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -2820,13 +2820,6 @@ int libxl__device_nic_setdefault(libxl__gc *gc, 
> libxl_device_nic *nic,
>      rc = libxl__resolve_domid(gc, nic->backend_domname, &nic->backend_domid);
>      if (rc < 0) return rc;
>
> -    if (nic->backend_domid != LIBXL_TOOLSTACK_DOMID && run_hotplug_scripts) {
> -        LOG(ERROR, "cannot use a backend domain different than %d if"
> -                   "hotplug scripts are executed from libxl",
> -                   LIBXL_TOOLSTACK_DOMID);
> -        return ERROR_FAIL;
> -    }
> -
>      switch (libxl__domain_type(gc, domid)) {
>      case LIBXL_DOMAIN_TYPE_HVM:
>          if (!nic->nictype)
> --
> 1.7.9.5
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel