Re: [Xen-devel] [PATCH] libxl: ignore run_hotplug_scripts setting when backend_domid!=0

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 04, 2013 at 03:23:51PM +0200, Roger Pau Monné wrote:
> On 04/07/13 14:40, George Dunlap wrote:
> > On 04/07/13 12:39, Roger Pau Monné wrote:
> >> On 04/07/13 12:42, George Dunlap wrote:
> >>> On Tue, Apr 9, 2013 at 9:49 AM, Marek Marczykowski
> >>> <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >>>> Instead of forcing the user to change run_hotplug_scripts setting
> >>>> globally, just ignore it for backends outside of dom0.
> >>>>
> >>>> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> >>> This seems like a good idea -- Roger / Ian, any thoughts?
> >> We already have this behaviour in libxl (see
> >> libxl_device.c:device_hotplug):
> >>
> >> /*
> >>   * If device is attached from a driver domain don't try to execute
> >>   * hotplug scripts
> >>   */
> >> if (aodev->dev->backend_domid != LIBXL_TOOLSTACK_DOMID)
> >>      goto out;
> >>
> >> This was introduced by commit 05bfd984dfe7014f1f5ea1133608b9bab589c120
> > 

What Marek's patch does is effectively Roger's commit 05bfd984 plus some
network specific bits. N.B. this patch predates 05bfd984.

> > But you still get an error on domain creation if you actually set a
> > non-dom0 backend and run_hotplug_scripts is set; so you can't actually
> > run in "mixed mode" anyway.  This patch should, I think, enable you to
> > have libxl run the scripts in dom0, but udev run them in domu.
> 

Long time ago Konrad sent me an email about running network backend in
another domain. The first thing to do is to disable hotplug script
globally.

Korand has some experience here and I think this patch *should* work,
because it basically does what Konrad told me to do.


Wei.

> Not for block devices that run in driver domains, but that might be true
> for network devices (I have not checked in libxl if the flow of network
> devices will error at some point if backend != 0).
> 
> For block devices you just need to follow
> http://wiki.xen.org/wiki/Storage_driver_domains, there's no need to
> perform any kind of obscure tricks to get it running.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel