Re: [Xen-devel] [PATCH 01/10] xen: arm: map memory as inner shareable.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-07-04 at 11:58 +0100, Tim Deegan wrote:
> At 17:10 +0100 on 28 Jun (1372439447), Ian Campbell wrote:
> > @@ -219,7 +249,7 @@ static inline lpae_t mfn_to_p2m_entry(unsigned long 
> > mfn, unsigned int mattr)
> >      lpae_t e = (lpae_t) {
> >          .p2m.xn = 0,
> >          .p2m.af = 1,
> > -        .p2m.sh = LPAE_SH_OUTER,
> > +        .p2m.sh = LPAE_SH_INNER,
> >          .p2m.write = 1,
> >          .p2m.read = 1,
> >          .p2m.mattr = mattr,
> 
> I think we need to leave MMIO mappings outer-shareable (or full-system
> as appropriate), which means adding the same mechanism that you did for
> the xen PT mappings. 

Yes, good catch.

THanks

> 
> Otherwise, this looks fine.
> 
> Cheers,
> 
> Tim.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel