Re: [Xen-devel] [PATCH v2] FIX: Cast the time_t values to avoid warnings

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-29 at 12:08 +0100, 7heo@xxxxxxx wrote:
> > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> > > index cb9c822..be1b446 100644
> > > --- a/tools/libxl/libxl_create.c
> > > +++ b/tools/libxl/libxl_create.c
> > > @@ -350,7 +350,7 @@ int libxl__domain_build(libxl__gc *gc,
> > >          vments[2] = "image/ostype";
> > >          vments[3] = "hvm";
> > >          vments[4] = "start_time";
> > > -        vments[5] = libxl__sprintf(gc, "%lu.%02d", 
> > > start_time.tv_sec,(int)start_time.tv_usec/10000);
> > > +        vments[5] = libxl__sprintf(gc, "%llu.%02d", (unsigned long long 
> > > int)(start_time.tv_sec),(int)start_time.tv_usec/10000);
> > 
> > These lines were overly long already but now they are really too long,
> > any chance you could wrap them a bit?
> Of course.

Did you send a v3 of this patch which I missed?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel