Re: [Xen-devel] [PATCH] Xen PV Device

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Stefano Stabellini [mailto:stefano.stabellini@xxxxxxxxxxxxx]
> Sent: 03 July 2013 17:38
> To: Paul Durrant
> Cc: qemu-devel@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; Stefano Stabellini;
> afaerber@xxxxxxx
> Subject: Re: [PATCH] Xen PV Device
> 
> On Wed, 3 Jul 2013, Paul Durrant wrote:
> > This patch introduces a new Xen PV PCI device which will act as a new
> > binding point for PV drivers for Xen.
> > The device has parameterized vendor-id, device-id and revision to allow to
> > be configured as a binding point for any vendor's PV drivers.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > ---
> >  hw/xen/Makefile.objs     |    1 +
> >  hw/xen/xen_pvdevice.c    |  131
> ++++++++++++++++++++++++++++++++++++++++++++++
> >  include/hw/pci/pci_ids.h |    5 +-
> >  trace-events             |    4 ++
> >  4 files changed, 139 insertions(+), 2 deletions(-)
> >  create mode 100644 hw/xen/xen_pvdevice.c
> >
> > diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> > index 2017560..fd88003 100644
> > --- a/hw/xen/Makefile.objs
> > +++ b/hw/xen/Makefile.objs
> > @@ -4,3 +4,4 @@ common-obj-$(CONFIG_XEN_BACKEND) +=
> xen_backend.o xen_devconfig.o
> >  obj-$(CONFIG_XEN_I386) += xen_platform.o xen_apic.o
> >  obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
> >  obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o
> xen_pt_config_init.o xen_pt_msi.o
> > +obj-$(CONFIG_XEN) += xen_pvdevice.o
> > diff --git a/hw/xen/xen_pvdevice.c b/hw/xen/xen_pvdevice.c
> > new file mode 100644
> > index 0000000..dbc4bf5
> > --- /dev/null
> > +++ b/hw/xen/xen_pvdevice.c
> > @@ -0,0 +1,131 @@
> > +/* Copyright (c) Citrix Systems Inc.
> > + * All rights reserved.
> 
> Like Anthony wrote before, All rights reserved contradicts what's
> written below.
> Aside from this, it looks OK to me.
> 
> I would like to see the libxl side patch.

Working on it, but it's not required to use the new device so I don't think the 
QEMU patch need be predicated on it.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel