Re: [Xen-devel] [Qemu-devel] [PATCH] Citrix PV Bus device

[Peter Maydell <peter.maydell@xxxxxxxxxx>]

On 2 July 2013 15:03, Paul Durrant <paul.durrant@xxxxxxxxxx> wrote:
> This patch introduces a new PCI device which will act as the binding point
> for Citrix branded PV drivers for Xen.
> The intention is that Citrix Windows PV drivers will be available on Windows
> Update and thus using the existing Xen platform PCI device as an anchor
> point is not desirable as that device has been ubiquitous in HVM guests for
> a long time and thus existing HVM guests running Windows would start
> automatically downloading drivers from Windows Update when this may not be
> desired by either the host or guest admin. This device therefore acts as
> an opt-in for those wishing to deploy Citrix PV drivers.

This commit message doesn't really make the case for having this
driver in upstream, IMHO. It sounds like it's only of use for your
branded product, which suggests that the best place for it is
probably in your product, not upstream.

> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>  hw/i386/Makefile.objs    |    1 +
>  hw/i386/citrix_pv_bus.c  |  126 
> ++++++++++++++++++++++++++++++++++++++++++++++

hw/i386 is also not the right place for this. hw/misc/ would
be better.

thanks
-- PMM

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel