Re: [Xen-devel] [Qemu-devel] [PATCH] Citrix PV Bus device

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx]
> Sent: 02 July 2013 11:54
> To: Andreas Färber
> Cc: Paul Durrant; qemu-devel@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxx;
> Michael S. Tsirkin
> Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device
> 
> Il 02/07/2013 12:45, Andreas Färber ha scritto:
> > Am 02.07.2013 10:39, schrieb Paul Durrant:
> >> This patch introduces a new PCI device which will act as the binding point
> >> for Citrix branded PV drivers for Xen.
> >> The intention is that Citrix Windows PV drivers will be available on
> Windows
> >> Update and thus using the existing Xen platform PCI device as an anchor
> >> point is not desirable as that device has been ubiquitous in HVM guests
> for
> >> a long time and thus existing HVM guests running Windows would start
> >> automatically downloading drivers from Windows Update when this may
> not be
> >> desired by either the host or guest admin. This device therefore acts as
> >> an opt-in for those wishing to deploy Citrix PV drivers.
> >>
> >> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> >> ---
> >>  hw/i386/Makefile.objs    |    1 +
> >>  hw/i386/citrix_pv_bus.c  |  122
> ++++++++++++++++++++++++++++++++++++++++++++++
> >>  include/hw/pci/pci_ids.h |    3 ++
> >>  3 files changed, 126 insertions(+)
> >>  create mode 100644 hw/i386/citrix_pv_bus.c
> >>
> >> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> >> index 205d22e..8e28831 100644
> >> --- a/hw/i386/Makefile.objs
> >> +++ b/hw/i386/Makefile.objs
> >> @@ -4,3 +4,4 @@ obj-y += pc.o pc_piix.o pc_q35.o
> >>  obj-$(CONFIG_XEN) += xen_domainbuild.o xen_machine_pv.o
> >>
> >>  obj-y += kvmvapic.o
> >> +obj-y += citrix_pv_bus.o
> >
> > So the reason to place the device here is TARGET_PAGE_SIZE... We really
> > need a way to access that value from common code, somewhere down my
> TODO
> > list. :/
> 
> Why does it need to be in pages rather than bytes?
> 

It doesn't necessarily need to be in pages; it's just a more convenient 
quantity than bytes. Since it needs to be a power of 2 I could perhaps use an 
'order' parameter instead?

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel