Re: [Xen-devel] [PATCH 07/10] xen: arm: Use dmb for smp barriers

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 28 Jun 2013, Ian Campbell wrote:
> The full power of dsb is not required in this context.
> 
> Also change wmb() to be dsb() directly instead of indirectly via mb(), for
> clarity.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


>  xen/include/asm-arm/system.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/include/asm-arm/system.h b/xen/include/asm-arm/system.h
> index e003624..89c61ef 100644
> --- a/xen/include/asm-arm/system.h
> +++ b/xen/include/asm-arm/system.h
> @@ -18,11 +18,11 @@
>  
>  #define mb()            dsb()
>  #define rmb()           dsb()
> -#define wmb()           mb()
> +#define wmb()           dsb()
>  
> -#define smp_mb()        mb()
> -#define smp_rmb()       rmb()
> -#define smp_wmb()       wmb()
> +#define smp_mb()        dmb()
> +#define smp_rmb()       dmb()
> +#define smp_wmb()       dmb()
>  
>  #define xchg(ptr,x) \
>          ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
> -- 
> 1.7.2.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel