Re: [Xen-devel] [PATCH 04/10] kexec: add infrastructure for handling kexec images

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 25/06/13 08:54, Jan Beulich wrote:
>>>> On 24.06.13 at 19:42, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
>> 
>> +        goto out;
>> +
>> +    image->control_page = ~0; /* By default this does not apply */
> 
> Use a recognizable #define instead?

This assignment serves no purpose so I'll leaved it zeroed.

>> +        mstart = image->segments[i].dest_maddr;
>> +        mend   = mstart + image->segments[i].dest_size;
>> +        if ( (mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK) )
> 
> Expressions like this can be abbreviated to
> 
>         if ( (mstart | mend) & ~PAGE_MASK )

I think the original more clearly reflects the intent.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel