Re: [Xen-devel] [PATCH 07/18] PVH xen: domain create, schedular related code changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.06.13 at 02:01, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> @@ -750,7 +753,10 @@ int arch_set_info_guest(
>      v->arch.pv_vcpu.iopl = (v->arch.user_regs.eflags >> 12) & 3;
>      v->arch.user_regs.eflags &= ~X86_EFLAGS_IOPL;
>  
> -    /* Ensure real hardware interrupts are enabled. */
> +    /*
> +     * Ensure real hardware interrupts are enabled. Note: PVH may not have
> +     * IDT set on all vcpus so we don't enable IF for it yet.
> +     */
>      v->arch.user_regs.eflags |= X86_EFLAGS_IF;
>  
>      if ( !v->is_initialised )

Please drop this comment change - it's confusing, as it
contradicts what the code is doing, and (just like for HVM) the
code is being bypassed for PVH.

> @@ -852,6 +858,7 @@ int arch_set_info_guest(
>  
>      set_bit(_VPF_in_reset, &v->pause_flags);
>  
> +pvh_skip_pv_stuff:

Labels should be indented by at least one space.

> @@ -942,6 +956,13 @@ int arch_set_info_guest(
>  
>      update_cr3(v);
>  
> +    if ( is_pvh_vcpu(v) )
> +    {
> +        /* Guest is bringing up non-boot SMP vcpu. */
> +        if ( (rc=hvm_set_vcpu_info(v, c.nat)) != 0 )

Coding style.

Also, if this is PVH specific, the function name should start with
pvh_.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel