Re: [Xen-devel] [PATCH] don't compile XEN_TMEM on ARM adn ARM64

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 24 Jun 2013, Konrad Rzeszutek Wilk wrote:
> On Mon, Jun 24, 2013 at 04:51:17PM +0100, Stefano Stabellini wrote:
> > Hi Konrad,
> > XEN_TMEM doesn't work on ARM64. This commit break Xen ARM64 in
> > linux-next:
> > 
> > commit 10a7a0771399a57a297fca9615450dbb3f88081a
> > Author: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> > Date:   Tue Apr 30 15:27:00 2013 -0700
> > 
> >     xen: tmem: enable Xen tmem shim to be built/loaded as a module
> > 
> > I suggest fixing it by disabling XEN_TMEM on everything non-x86.
> 
> Hm, what is the compile issue?

drivers/xen/tmem.c: In function âxen_tmem_opâ:
drivers/xen/tmem.c:105:2: error: implicit declaration of function 
âHYPERVISOR_tmem_opâ [-Werror=implicit-function-declaration]

Alternatively I can provide the implementation of HYPERVISOR_tmem_op.

---

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

diff --git a/arch/arm/include/asm/xen/hypercall.h 
b/arch/arm/include/asm/xen/hypercall.h
index 799f42e..f546b27 100644
--- a/arch/arm/include/asm/xen/hypercall.h
+++ b/arch/arm/include/asm/xen/hypercall.h
@@ -47,6 +47,7 @@ unsigned long HYPERVISOR_hvm_op(int op, void *arg);
 int HYPERVISOR_memory_op(unsigned int cmd, void *arg);
 int HYPERVISOR_physdev_op(int cmd, void *arg);
 int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args);
+int HYPERVISOR_tmem_op(void *arg);
 
 static inline void
 MULTI_update_va_mapping(struct multicall_entry *mcl, unsigned long va,
diff --git a/arch/arm/xen/hypercall.S b/arch/arm/xen/hypercall.S
index 199cb2d..d1cf7b7 100644
--- a/arch/arm/xen/hypercall.S
+++ b/arch/arm/xen/hypercall.S
@@ -88,6 +88,7 @@ HYPERCALL2(hvm_op);
 HYPERCALL2(memory_op);
 HYPERCALL2(physdev_op);
 HYPERCALL3(vcpu_op);
+HYPERCALL1(tmem_op);
 
 ENTRY(privcmd_call)
        stmdb sp!, {r4}
diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S
index 2816c47..531342e 100644
--- a/arch/arm64/xen/hypercall.S
+++ b/arch/arm64/xen/hypercall.S
@@ -79,6 +79,7 @@ HYPERCALL2(hvm_op);
 HYPERCALL2(memory_op);
 HYPERCALL2(physdev_op);
 HYPERCALL3(vcpu_op);
+HYPERCALL1(tmem_op);
 
 ENTRY(privcmd_call)
        mov x16, x0

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel