[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] don't compile XEN_TMEM on ARM adn ARM64



>>> On 24.06.13 at 17:51, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
> Hi Konrad,
> XEN_TMEM doesn't work on ARM64. This commit break Xen ARM64 in
> linux-next:
> 
> commit 10a7a0771399a57a297fca9615450dbb3f88081a
> Author: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> Date:   Tue Apr 30 15:27:00 2013 -0700
> 
>     xen: tmem: enable Xen tmem shim to be built/loaded as a module
> 
> I suggest fixing it by disabling XEN_TMEM on everything non-x86.

That's pretty gross - the kernel side tmem code should be really
architecture independent, so shouldn't even need the !ARM
dependency.

Jan

> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 9e02d60..c1ac85b 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -145,7 +145,7 @@ config SWIOTLB_XEN
>  
>  config XEN_TMEM
>       tristate
> -     depends on !ARM
> +     depends on X86
>       default m if (CLEANCACHE || FRONTSWAP)
>       help
>         Shim to interface in-kernel Transcendent Memory hooks
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.