Re: [Xen-devel] [PATCH v3 8/8] libxl, hvmloader: Don't relocate memory for MMIO hole

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 21/06/13 08:17, Jan Beulich wrote:
> > > > On 20.06.13 at 18:33, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > @@ -57,6 +59,32 @@ void pci_setup(void)
> >       } *bars = (struct bars *)scratch_start;
> >       unsigned int i, nr_bars = 0;
> >   
> > +    const char *s;
> > +    /*
> > +     * Do we allow hvmloader to relocate guest memory in order to
> > +     * increase the size of the lowmem MMIO hole?  Defaulting to 1
> > +     * here will mean that non-libxl toolstacks (including xend and
> > +     * home-grown ones) will experience this series as "no change".
> > +     * It does mean that those using qemu-xen will still experience
> > +     * the bug (described below); but it also means that those using
> > +     * qemu-traditional will *not* experience any change; and it also
> > +     * means that there is a work-around for those using qemu-xen,
> > +     * namely switching to qemu-traditional.
> > +     *
> > +     * If we defaulted to 0, and failing to resize the hole caused any
> > +     * problems with qemu-traditional, then there is no work-around.
> > +     *
> > +     * Since xend can't talk to qemu-traditional, I think this is the
> qemu-xen?
Oops, good catch. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel