Re: [Xen-devel] [PATCH v2 5/5] libxl, hvmloader: Don't relocate memory for MMIO hole

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 20/06/13 14:35, Ian Jackson wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH v2 5/5] libxl, hvmloader: Don't 
> relocate memory for MMIO hole"):
> > I think I'd be more inclined to do allow_memory_relocate = strcmp(s,
> > "0");  That will have more predictable results (e.g., 0 is false,
> > anything else at all is true).
> This is a real bikeshed issue, but:
>
> IMO the strtoll is fine and is superior to strcmp(), direct string
> inspection, etc.  If we are representing booleans as integers written
> out in ASCII, we should be using an integer parsing function, not
> cooking up our own half-arsed not-quite-integer parser.
Right -- so I'll paint the bike shed "allow_memory_relocate = 
strtoll()", removing the cast to bool.
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel