Re: [Xen-devel] [PATCH v2 4/5] hvmloader: Fix check for needing a 64-bit bar

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 20/06/13 11:01, Jan Beulich wrote:
> > > > On 18.06.13 at 18:46, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > After attempting to resize the MMIO hole, the check to determine
> > whether there is a need to relocate BARs into 64-bit space checks the
> > specific thing that caused the loop to exit (MMIO hole == 2GiB) rather
> > than checking whether the required MMIO will fit in the hole.
> >
> > This should have no functional change now, but will make the next patch
> > (when we add more conditions for exiting the loop) more clean.
> This does change functionality, but in a desirable way: With what
> the code did before, even if pci_mem_start remained at its start
> value, bar64_relocate would end up getting set to 1, while it would
> be left at 0 when pci_mem_start got lowered down to 2Gb. I.e. it
> seems to me that the original condition was inverted.
Oh -- good point.  But the relocation was never triggered before because 
bar_sz was always < mmio_left.
In that case, this patch should go earlier in the series, before we 
actually start doing functional changes.
 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel