[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] x86/vtsc: update vcpu_time in hvm_set_guest_time



On 04/06/13 14:59, Alex Bligh wrote:


--On 4 June 2013 14:09:31 +0100 George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:

On 06/04/2013 01:49 PM, Roger Pau Monne wrote:
When using a vtsc, hvm_set_guest_time changes hvm_vcpu.stime_offset,
which is used in the vcpu time structure to calculate the
tsc_timestamp, so after updating stime_offset we need to propagate the
change to vcpu_time in order for the guest to get the right time if
using the PV clock.

Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
Cc: Keir Fraser <keir@xxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Diana / Alex, want to give this one a spin?

We will do. If it works we will test a 4.2.2 backport too.

I have tested patch-v2 with xen4.3 and it did not get a clock stuck yet across mutiple migrations between hosts (i.e. not localhost). I have patched in v3 and will do some further stress testing tomorrow. Once it works I will also test a backport to 4.2.2 and also give an update.

Thanks,
Diana


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.