[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] A simple question regarding hvm_context_save



Hello,
I'm reading live migration related code and got a simple question 
in function hvm_context_save:

static int hvm_save_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
{
blah...
        /* We don't need to save state for a vcpu that is down; the restore 
         * code will leave it down if there is nothing saved. */
        if ( test_bit(_VPF_down, &v->pause_flags) )
            continue;
blah...

In the above, if the vcpu is paused, we don't need to store cpu registers
(since vcpu structure already stored them). But, as far as I know, before
we save the hvm context, we suspend the domain, which calls shutdown 
sched_op, and the vcpu is paused. 
Then, I guess testing pause_flags always returns down and we don't
need to store cpu ctxts. Do I miss something here?

best,
Jaeyong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.