Re: [Xen-devel] [PATCH] xl: Return an error if an empty file is passed to cd-insert

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-05-14 at 11:07 +0100, George Dunlap wrote:
> Two changes:
> * Stat the file before calling libxl_cdrom_insert()
> * Return an error if anything fails (including libxl_cdrom_insert)
> 
> This is in part to work around the fact that the RAW disk type
> is used for things that aren't actually files; so we can't call
> stat in libxl_device.c:libxl__device_disk_set_backend() because
> it may be going over a remote protocol.
> 
> v2:
>  - Avoid leaking buf
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Acked + applied, thanks.

> +    /* ATM the existence of the backing file is not checked for qdisk
> +     * in libxl_cdrom_insert() because RAW is used for remote
> +     * protocols as well as plain files.  This will ideally be changed
> +     * for 4.4, but this work-around fixes the problem of "cd-insert"
> +     * returning success for non-existent files. */

Is this on your 4.4 list?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel