[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init

Il 29/05/2013 14:11, Andreas Färber ha scritto:
>> xen_machine_pv uses cpu_x86_init, therefore it has been broken.
>> This patch fixes the problem by removing the dummy CPU creation
>> altogether from xen_init_pv, relying on the fact that QEMU can now cope
>> with a machine without an emulated CPU.
>> This fix should be backported to QEMU 1.5.
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> CC: imammedo@xxxxxxxxxx
>> CC: qemu-stable@xxxxxxxxxx
> Change looks okay,
> Reviewed-by: Andreas Färber <afaerber@xxxxxxx>
> But for the future please avoid "this patch" in the commit message
> (because later on it's a "commit", not a patch) and also please put
> additional notices such as for backporting below the --- line.

I read it as a warning to backporters that the patch, even though it may
apply, was not tested and may even be wrong in 1.4.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.