Re: [Xen-devel] [PATCH] xen/arm: Rework the way to compute dom0 DTB base address

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> >>      if ( ret < 0 )
> >>          goto err;
> >>  
> >> -    /*
> >> -     * Put the device tree at the beginning of the first bank.  It
> >> -     * must be below 4 GiB.
> >> -     */
> >> -    kinfo->dtb_paddr = kinfo->mem.bank[0].start + 0x100;
> >>      if ( kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt) > (1ull << 32) )
> > 
> > Isn't this check now misplaced?
> 
> 
> Right. I think we can remove kinfo->dtb_paddr and just check the DTB
> size is less than 4GiB.

Is it easy to check for overlap with the kernel and provide a useful
message in that case?

> > What do you think of aligning to e.g. a 2MB boundary?
> 
> Sounds good for, in fact, I wanted to avoid a big wasted space after the
> DTB. I will send a new version of this patch with all the modifications.

Thanks,
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel