[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface

On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote:
> >> +     notify_remote_via_evtchn(priv->evtchn);
> >> +
> >> +     ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
> >
> > Um, + 6? Why? Is there an #define for that magic constant?
> > Should this value be read before you do the wait_for_tpm_stat stuff?
>   This is hardcoded to 6 even in tpm.c.  Time for a #define...
> > Otherwise it looks OK to me. Should this go through me or Kent?
> > And if so, is Kent waiting for my feedback?
>   My comments were minor -- I was expecting feedback on your earlier
> comments before merging.  I think this should go through the tpmdd
> maintainer if its going to live in drivers/char/tpm though.

That is you I thought?

konrad@phenom:~/mm$ scripts/get_maintainer.pl -f drivers/char/tpm
Kent Yoder <key@xxxxxxxxxxxxxxxxxx> (maintainer:TPM DEVICE DRIVER)
Rajiv Andrade <mail@xxxxxxxxxx> (maintainer:TPM DEVICE DRIVER)
Marcel Selhorst <tpmdd@xxxxxxxxxxxx> (maintainer:TPM DEVICE DRIVER)
Sirrix AG <tpmdd@xxxxxxxxxx> (maintainer:TPM DEVICE DRIVER)
tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx (moderated list:TPM DEVICE DRIVER)
linux-kernel@xxxxxxxxxxxxxxx (open list)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.