[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch[ xl problems with xendomains

  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • From: Ian Murray <murrayie@xxxxxxxxxxx>
  • Date: Wed, 22 May 2013 12:44:19 +0100 (BST)
  • Cc: "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Wed, 22 May 2013 11:45:56 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.co.uk; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=qnQQ8VqD8+yKgbuD7zZriIKLE5SolzLORm8P6RHJT8ozQ87NVHz0D6TR+jB3u9asNCO252FBogp4TOAEQSdSC+35VgAKrnu335pA2629gOoFiDKWv/bEk/adp5OW3gy5ho+ABl4BOcFk3pSoXDEplzsHV6IeXv4O/WmARicoVYE=;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

----- Original Message -----
> From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> To: Ian Murray <murrayie@xxxxxxxxxxx>
> Cc: ian.jackson@xxxxxxxxxxxxx; xen-devel <xen-devel@xxxxxxxxxxxxx>
> Sent: Wednesday, 22 May 2013, 10:53
> Subject: Re: [Xen-devel] [Patch[ xl problems with xendomains

> $HEADER presumably includes spaces, because the xl save header does, and
> therefore requires quoting. This was also broken for xm because even
> though the xm save header has no spaces the point of this check is to
> look for corrupt/invalid save files, which may well have a space.

Yeah, by that point $HEADER should have "Xen saved domain" which indeed does 
include spaces. Makes perfect sense.

> It looks correct to me.

Great. :)

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> That actual patch seems to be a bit mangled (looks like an unresolved
> git conflict 3 way diff thing). Since it is simple I can fix it up as I
> apply.

I just diffed the original file with a changed version. Anyway, as you say, 
whatever the issue, it's pretty obvious what is going on.

Thanks for actioning it and look forward to see it in Xen, whenever that is.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.