[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/makefile: Allow XEN_CHANGESET to be set externally

On Fri, 2013-05-17 at 15:41 +0100, Andrew Cooper wrote:
> On 17/05/2013 15:32, Olaf Hering wrote:
> > On Fri, May 17, Andrew Cooper wrote:
> >
> >> Build systems based on tarballs rather than source code trees, such as
> >> rpms/debs are unable to obtain changeset infomation.
> >>
> >> Allow XEN_CHANGESET to be optionally specified in the environment.
> > Isnt that already possible with 'echo "$XEN_CHANGESET" > .scmversion'?
> >
> > Olaf
> No - that results in the literal string "$XEN_CHANGESET"

No, because your shell would expand it. In any case Olaf's point was
obviously that you could write whatever string you would like to that
file and it would have exactly the same effect as overriding
XEN_CHANGESET when calling make. I expect it's also a little less prone
to forgetting to pass it to make on every call.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.