Re: [Xen-devel] [PATCH V3] libxl: write IO ABI for disk frontends

[Valtteri Kiviniemi <kiviniemi.valtteri@xxxxxxxxx>]

2013/5/17 Wei Liu <wei.liu2@xxxxxxxxxx>

On Fri, May 17, 2013 at 10:18:05AM +0100, George Dunlap wrote:
> On 05/17/2013 10:07 AM, Wei Liu wrote:
> >On Fri, May 17, 2013 at 09:56:38AM +0100, George Dunlap wrote:
> >[...]
> >>>>with Xen 4.3-rc1 and with xl tool stack. So the patch is working as
> >>>>intented. I also tested various xl commands and functions with my legacy
> >>>>domU and all of them seemed to be working (reboot, pause, unpause, shutdown
> >>>
> >>>Thanks for testing.
> >>>
> >>>>etc.) except suspend. Suspend crashes with "Internal error" and the guest
> >>>>console shows error message "Can't suspend SMP guests without
> >>>>CONFIG_HOTPLUG_CPU".
> >>>>
> >>>>2.6.16.33 kernel does not seem to have cpu hotplug support, or then I just
> >>>>can find it in the kernel menuconfig.
> >>>>
> >>>
> >>>George, should this one be added to your list? (Just found out you're
> >>>already in CC ;-) )
> >>
> >>...add "Linux 2.6.16.33 HOTPLUG config option is hard to find" to my
> >>list?  I'm not sure that would be a 4.3 release blocker... :-)
> >>
> >
> >I mean 'xl suspend' crashes with "Internal Error". Should not be a
> >blocker, but at least worthy of making its way to known issues list? (if
> >there is one).
>
> Well if it *fails* with "Internal Error" because there's an internal
> error, I'm not sure that's a bug. :-)
>

The "crash" bugs me. If it is a normal exit that's fine.

> If Valtteri wants to post a proper bug report, with the listed
> output and a suggestion of what would be a better output, we can
> consider putting it on the list.
>

Valtteri now it is up to you. :-)


Wei.

Hi,

I'm now at holiday couple of weeks but after that I will double check my kernel config and post a proper bug report if needed. I just had this feeling that the pre 4.0 xen versions (for example xen 3.4 with 2.6.18 xenified kernel) handled the suspend differently and figured that maybe there is still something missing from xl toolstack. That 2.6.16 kernel is so old that I just assumed that it does not have cpu hotplug support and figured that maybe it is something that xl toolstack does not handle. But you are probably right, I'm just blind and missed the option in the menuconfig :)

Its hard to remember all the changes that has happened in Xen and Linux kernels and which options need to be enabled etc. But I will test it more thoroughly after my holiday.

- Valteri

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel