[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] x86/hvm: fix corrupt ACPI PM-Timer during live migration

At 14:27 +0900 on 16 May (1368714430), Kouya Shimura wrote:
> Hi Keir, Tim,
> I attached the patch again.
> Can I get an ACK or NACK?

Well, I don't think this is suitable for committing:

> +#if 0 /* redundant */
>      if ( !mode_is(v->domain, delay_for_missed_ticks) )
>          return;
> +#endif

but apart from that it seems OK to me.  It's a bit odd to have the
platform timers (almost) stop ticking when their controlling vcpu is
descheduled but I guess no worse than having them go backwards!

So if you fix the '#if 0' (either cut out the code properly or leave it
alone, I don't mind which), you can add

Reviewed-by: Tim Deegan <tim@xxxxxxx>

You'll need an ack from George as well for the release; I suspect that
will depend on how much testing you've done.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.