[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/5] hypervisor/xen/tools: Remove the XENMEM_get_oustanding_pages and provide the data via xc_phys_info

On Mon, 2013-05-13 at 20:29 +0100, Konrad Rzeszutek Wilk wrote:
> During the review of the patches it was noticed that there exists
> a race wherein the 'free_memory' value consists of information from
> two hypercalls. That is the XEN_SYSCTL_physinfo and 
> XENMEM_get_outstanding_pages.
> The free memory the host has available for guest is the difference between
> the 'free_pages' (from XEN_SYSCTL_physinfo) and 'outstanding_pages'. As they
> are two hypercalls many things can happen in between the execution of them.
> This patch resolves this by eliminating the XENMEM_get_outstanding_pages
> hypercall and providing the free_pages and outstanding_pages information
> via the xc_phys_info structure.
> It also removes the XSM hooks and adds locking as needed.
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> Reviewed-by: Tim Deegan <tim@xxxxxxx>
> Acked-by: Keir Fraser <keir.xen@xxxxxxxxx>
> [v1: Fix missing XSM hooks cleanups, fixed get_outstanding_claims fnc,
>   add Acked/Reviewed-by]
> [v2: s/%ld/PRIu64/ as we don't use 'long' anymore]
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

I think we've discussed this before but your tags should be in a roughly
chronological order, not backwards in time as you have them. Or at least
that's how everyone else does it.

Also the intra-version changelog should go afterwards following a "---"
so it is stripped from the final commit.

I've fixed this as I applied #2..#5. #1 was already in since before your
previous posting.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.