Re: [Xen-devel] [PATCH 2/3] piix4acpi, xen: Clarify that the qemu_set_irq calls just do an IRQ pulse.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 13 May 2013, Konrad Rzeszutek Wilk wrote:
> The "qemu_cpu_notify" raises and lowers the ACPI SCI line when the
> vCPU state has changed.
> 
> Instead of doing the two functions, just use one function that
> describes exactly what it does.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


>  hw/piix4acpi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/piix4acpi.c b/hw/piix4acpi.c
> index 54d566b..bf916d9 100644
> --- a/hw/piix4acpi.c
> +++ b/hw/piix4acpi.c
> @@ -834,8 +834,6 @@ int qemu_cpu_add_remove(int cpu, int state)
>  }
>  void qemu_cpu_notify(void)
>  {
> -    if (gpe_state.gpe0_en[0] & 4) {
> -        qemu_set_irq(sci_irq, 1);
> -        qemu_set_irq(sci_irq, 0);
> -    }
> +    if (gpe_state.gpe0_en[0] & 4)
> +        qemu_irq_pulse(sci_irq);
>  }
> -- 
> 1.8.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel