Re: [Xen-devel] [PATCH V4 02/32] xen/mm: Align virtual address on PAGE_SIZE in iounmap

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-10 at 16:11 +0100, Julien Grall wrote:
> ioremap function can unlikely return an unaligned virtual address if
> the physical address itself is unaligned on a page size.

On x86 this causes:
In file included from 
/local/scratch/ianc/devel/committer.git/xen/include/asm/io.h:5,
                 from 
/local/scratch/ianc/devel/committer.git/xen/include/asm/mc146818rtc.h:8,
                 from rtc.c:26:
/local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h: In function 
âiounmapâ:
/local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h:20: error: 
âPAGE_MASKâ undeclared (first use in this function)
/local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h:20: error: (Each 
undeclared identifier is reported only once
/local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h:20: error: for 
each function it appears in.)
make[5]: *** [rtc.o] Error 1
make[5]: *** Waiting for unfinished jobs....

Since I had already prepared the branch for commit/push and it was a bit
of a faff I will fold in the following patchlet:

diff --git a/xen/include/xen/vmap.h b/xen/include/xen/vmap.h
index daee7f5..b1923dd 100644
--- a/xen/include/xen/vmap.h
+++ b/xen/include/xen/vmap.h
@@ -2,6 +2,7 @@
 #define __XEN_VMAP_H__
 
 #include <xen/types.h>
+#include <asm/page.h>
 
 void *vm_alloc(unsigned int nr, unsigned int align);
 void vm_free(const void *);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel