Re: [Xen-devel] [PATCH V3 28/41] xen/arm: Add generic UART to get the device in the device tree

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/10/2013 10:32 AM, Ian Campbell wrote:

> On Fri, 2013-05-10 at 03:18 +0100, Julien Grall wrote:
>> This generic UART will find the right UART via xen command line
>> with dtuart=myserial.
>>
>> "myserial" is the alias of the UART in the device tree. Xen will retrieve
>> the information via the device tree and call the initialization function for
>> this specific UART thanks to the device API.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> 
>> CC: keir@xxxxxxx
>>
>> Changes in v3:
>>     - Rename arm-uart.c (resp. arm_uart_init) to dt-uart.c (resp. 
>> dt_uart_init)
>>     - Remove serial_arm_defaults and replace by a string options
>>     - Let the specific UART driver to get its base address in the DT
>>     - Add SERHND_DTUART. The value is stolen to SERHND_COM1. Bump the
>>     value would needs some rework...
> 
> This is because of the need to encode the value in 2 bits? Due to
> SERHND_IDX etc, is the rework more than simply changing the mask and
> bumping the flags up and increasing the size of the com array?

The console code is able to handle one serial at time so, I don't
understand why we need to "waste" another memory space for a new kind of
serial.

> I'm OK with this for 4.3 if Keir is:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> 


-- 
Julien

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel