Re: [Xen-devel] [PATCH V2 15/33] xen/arm: Use hierarchical device tree to retrieve GIC information

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 16:49 +0100, Julien Grall wrote:
> On 05/08/2013 02:46 PM, Ian Campbell wrote:

> > Please can we keep this last check separate and after the print, this
> > way we get to see why it failed (not present vs invalid).
> 
> 
> I will fix it on the next patch series.

Thanks.

> > 
> > I'm ambivalent about keeping the !gic.Xbase separate or including it in
> > the res check.
> 
> 
> I don't see a good reason why the gic base address could not be 0. I
> prefer to remove this check.

True, agreed.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel