Re: [Xen-devel] [PATCH 2/3] xen/arm: do not handle VCPUOP_register_vcpu_info failures

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 13:11 +0100, Stefano Stabellini wrote:
> We expect VCPUOP_register_vcpu_info to succeed, do not try to handle
> failures.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  arch/arm/xen/enlighten.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 83d13b0..519acf9 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -165,13 +165,10 @@ static int __init xen_secondary_init(unsigned int cpu)
>       info.offset = offset_in_page(vcpup);
>  
>       err = HYPERVISOR_vcpu_op(VCPUOP_register_vcpu_info, cpu, &info);
> -     if (err) {
> -             pr_debug("register_vcpu_info failed: err=%d\n", err);
> -     } else {
> -             /* This cpu is using the registered vcpu info, even if
> -                later ones fail to. */
> -             per_cpu(xen_vcpu, cpu) = vcpup;
> -     }
> +     if (err)
> +             BUG();

AKA BUG_ON(err);

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> +     per_cpu(xen_vcpu, cpu) = vcpup;
> +
>       return 0;
>  }
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel