[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Make 'xl vcpu-set' work properly on overcommited hosts.

On Wed, 2013-05-08 at 11:32 +0100, George Dunlap wrote:
> On Tue, May 7, 2013 at 9:40 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx> wrote:
> > The libxl_cpu_bitmap_alloc(..) function, if provided with a zero
> > value for max CPUs will call xc_get_max_cpus() which will retrieve
> > the number of physical CPUs the host has. This is usually
> > OK if the guest's maxvcpus <= host pcpus. But if the value
> > is different, then the bitmap for VCPUs is limited by the
> > number of CPUs the host has.
> >
> > This is incorrect as what we want is to hotplug in the guest
> > the amount of CPUs that the user specified on the command line
> > and not be limited by the amount of physical CPUs.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Given the cost/benefits of this, I'm inclined to say this should wait
> until the 4.4 window opens.  Having more guest vcpus than host pcpus
> is not an urgent need, and there is a chance (however small) of this
> exposing some other kind of bug.

Not disputing this.

I imagine the desire is to add vcpus to a guest after migrating to a
larger host. If so then this should be in the commit log because you are
right that as the commit message currently stands the immediate response
is "why on earth..."

My only other concern would be that the existing code has a buffer
overrun under these circumstances. I've not checked this either.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.